Remove dependency on github.com/docker/docker#149
Draft
akerouanton wants to merge 6 commits intodocker:mainfrom
Draft
Remove dependency on github.com/docker/docker#149akerouanton wants to merge 6 commits intodocker:mainfrom
akerouanton wants to merge 6 commits intodocker:mainfrom
Conversation
Using the lowest version of docker/docker still maintained (23.0 is maintained as LTS version by mirantis) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Update to use the currently maintained version of this dependency, which is also used elsewhere. Signed-off-by: Sebastiaan van Stijn <[email protected]>
It was only used for basic assertions; replace those with stdlib Signed-off-by: Sebastiaan van Stijn <[email protected]>
It was added in 008703b, but none of the functions are exported, and none of them are currently called. Signed-off-by: Sebastiaan van Stijn <[email protected]>
The volume shim driver was introduced in commit 61113e3. It's supposed to help plugin authors focus on the volume driver API, rather than the plugin API. However, this means the plugins SDK is pulling in github.com/docker/docker. Since moby/moby@04f5276, the Engine's volume package has been moved into the daemon package, and is considered an implementation detail that no one should import. Looking at the use of `NewHandlerFromVolumeDriver` on grep.app, and Sourcegraph, it seems no one is using it. So drop it unceremoniously. Signed-off-by: Albin Kerouanton <[email protected]>
This makes it possible to import this module into github.com/moby/moby such that we can avoid duplicating Go API types across repos. Signed-off-by: Albin Kerouanton <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR removes the dependency on github.com/docker/docker by dropping the volume shim driver functionality and updating the module dependencies. The shim driver was originally designed to help plugin authors focus on the volume driver API rather than the plugin API, but it introduced an unwanted dependency on Docker Engine internals.
- Completely removes the volume shim driver package (
volume/shim/) - Removes unused systemd socket activation code
- Updates test code to remove external test dependency
- Modernizes build configuration
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| volume/shim/shim.go | Complete removal of shim driver implementation |
| volume/shim/shim_test.go | Complete removal of shim driver tests |
| sdk/unix_listener_systemd.go | Removes unused systemd socket activation code |
| sdk/unix_listener_nosystemd.go | Removes unused systemd socket activation stub |
| go.mod | Updates module dependencies, removes docker/docker dependency |
| authorization/api_test.go | Replaces testify/require with standard library assertions |
| Makefile | Updates build configuration and dependency installation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
volume/shim: drop it
The volume shim driver was introduced in commit 61113e3. It's supposed to help plugin authors focus on the volume driver API, rather than the plugin API. However, this means the plugins SDK is pulling in github.com/docker/docker.
Since moby/moby@04f5276, the Engine's volume package has been moved into the daemon package, and is considered an implementation detail that no one should import.
Looking at the use of
NewHandlerFromVolumeDriveron grep.app, and Sourcegraph, it seems no one is using it. So drop it unceremoniously.go.mod: remove dependency on github.com/docker/docker
This makes it possible to import this module into github.com/moby/moby such that we can avoid duplicating Go API types across repos.